[Webkit-unassigned] [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117728


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204920|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Christophe Dumez <dchris at gmail.com>  2013-06-18 10:18:40 PST ---
(From update of attachment 204920)
View in context: https://bugs.webkit.org/attachment.cgi?id=204920&action=review

LGTM. r=me with nits. Please let Grzegorz have a look before landing.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:228
> +static Ewk_Context_Menu_Item* findContextMenuItem(Ewk_Context_Menu* contextMenu, const Ewk_Context_Menu_Item_Action& itemAction, const Ewk_Context_Menu_Item_Type& itemType)

nit: contextMenu could be a const pointer, and it is overkill to pass enum types by const reference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.