[Webkit-unassigned] [Bug 117736] [GStreamer] Potential race condition when getting the video sink caps.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117736


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204913|review?                     |review-
               Flag|                            |




--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2013-06-18 08:17:31 PST ---
(From update of attachment 204913)
View in context: https://bugs.webkit.org/attachment.cgi?id=204913&action=review

Ok, just a couple of nitpicks:

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:302
> +static void webkitVideoSinkGetProperty(GObject *object, guint propId, GValue *value, GParamSpec *pspec)

The stars are misplaced, we also prefer to use longer names, like propertyId and parameterSpec

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:492
> +    GstCaps* currentCaps;

Please move this just before the g_object_get() call

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.