[Webkit-unassigned] [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117728


Grzegorz Czajkowski <g.czajkowski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |g.czajkowski at samsung.com




--- Comment #7 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2013-06-18 06:25:10 PST ---
(In reply to comment #6)
> (From update of attachment 204895 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204895&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:433
> > +    ASSERT_FALSE(waitUntilTrue(callbacksExecutionStats.settingChange, defaultTimeoutInSeconds));
> 
> I think such checks slow down the api tests. maybe we should use 0 as defaultTimeoutInSeconds instead so that we process the event loop only once.

Sounds fine for me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.