[Webkit-unassigned] [Bug 117156] [GTK] Migrate WebKitFaviconDatabase to GTask

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 00:02:15 PDT 2013


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-18 00:00:53 PST ---
(In reply to comment #3)
> (From update of attachment 203601 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203601&action=review
> > Source/WebKit2/UIProcess/API/gtk/WebKitFaviconDatabase.cpp:-172
> > -        if (!g_cancellable_is_cancelled(data->cancellable.get())) {
> I just couldn't figure out why you're no longer checking for cancellation here, the rest looks good to me.

That was to make sure that cancelled error had precedence over any other error, so we just completed the operation with g_simple_async_result_complete(). With GTask cancellation always has precedence (when check_cancellable is TRUE, which is the default), because all g_task_propagate methods first check if task was cancelled, so here we ignore the cancelled and complete the operation either with g_task_return_error or g_task_return_boolean, in both cases cancellation will be handled in the finish method when calling g_task_propagate_boolean.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list