[Webkit-unassigned] [Bug 117695] [WinCairo] Webfont rendering is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117695





--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-06-17 22:23:30 PST ---
(From update of attachment 204821)
View in context: https://bugs.webkit.org/attachment.cgi?id=204821&action=review

I think this looks good, but I'd like Martin Robinson to double-check that we aren't doing something bad to the Gtk+ port.  I also had a few questions I'd like you to double-check for me before I r+ the patch. Thanks!

> Source/WebCore/platform/graphics/FontPlatformData.h:109
> +    FontPlatformData(HFONT, cairo_font_face_t*, float size, bool bold, bool italic);

It seems like this should break Gtk+, but the EWS says its okay... It seems like this should maybe be protected by USE(WINCAIRO).

> Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:82
>  FontCustomPlatformData* createFontCustomPlatformData(SharedBuffer* buffer)

Should this be declared static now? It's not used outside this module, is it?

> Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.h:-49
> -    cairo_font_face_t* m_fontFace;

Is there no benefit to holding the cairo_font_fact_t*?  Is it needed anywhere else?

> Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp:60
> +    : m_font(RefCountedGDIHandle<HFONT>::create(font))

Good!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.