[Webkit-unassigned] [Bug 109212] TDs not always removing border when losing CSS class that gives them the border

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109212





--- Comment #10 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-06-17 19:36:07 PST ---
Hi Simon,

Thank you for reviewing.

(In reply to comment #9)
> Not sure, really. I'd investigate to see why this isn't a problem for other boxes when borders change.

The rect of RenderBox is always border box. This dose not depend on box-sizing property.
When border-width of a block is changed, we need to re-layout.
Before laying out the block, we save the original rect to LayoutRepainter at RenderBlock::layout().
After laying out the block, we repaint the original rect and the new rect.
Therefore, this isn't a problem for normal boxes when borders change.

However, the rect of RenderTableCell which border is collapsed contains half of its border width.
Therefore, we need to add other half of the border width to its rect when we calculate repaint rect.

I don't remember another CSS values which I need to investigate.
If you have concern about another CSS values, I can investigate them.

If adding RenderTableCell rect to visual overflow is not correct approach, I think we need to save the rect to    a member of RenderTableCell.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.