[Webkit-unassigned] [Bug 117667] Expose a getMediaType method in WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117667


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204860|review?                     |review-
               Flag|                            |




--- Comment #8 from Brady Eidson <beidson at apple.com>  2013-06-17 15:53:50 PST ---
(From update of attachment 204860)
View in context: https://bugs.webkit.org/attachment.cgi?id=204860&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:111
> +    if (node->nodeType() != Node::ELEMENT_NODE)
> +        return kWKBundleHitTestResultMediaTypeNone;

This should probably be if (node->isElementNode()) instead.  Sorry for not catching that earlier.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:32
>  #include <WebCore/HitTestResult.h>
> +#include <WebKit2/WKBundleHitTestResult.h>
>  #include <wtf/Forward.h>

Seeing this in the flesh set off a red flag - We shouldn't be directly including API headers in implementation files when we can avoid it.

I've suggested to Ruth on IRC a path forward with an API set of enums, an impl set of enums, and API casting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.