[Webkit-unassigned] [Bug 117667] Expose the mediaIsVideo method in WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117667


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204752|review?                     |review-
               Flag|                            |




--- Comment #3 from Brady Eidson <beidson at apple.com>  2013-06-17 11:28:00 PST ---
(From update of attachment 204752)
Style seems fine here, but I'm not convinced this API is the way to go.

Asking a WKBundleHitTestResult if the media is video for a non-media element is kind of weird.  Of course it's not video - It's a div, or a img!

The client would have to first determine that the hit test result represents a media element by getting the media src URL (which is kind of a weird way to determine that...) and then use this API.

The new API should probably be a general purpose "what kind of media element is this?" call.  To start with it could return:
kWKMediaTypeAudio
kWKMediaTypeVideo
kWKMediaTypeNone

This removes some burden on the client and is also expandable in the future when we add <smell>, <taste>, or <touch>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.