[Webkit-unassigned] [Bug 117649] [GTK][WK2] adding subtitles (with toggle button) on html videos

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117649


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204729|review?                     |review-
               Flag|                            |




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-16 23:51:39 PST ---
(From update of attachment 204729)
View in context: https://bugs.webkit.org/attachment.cgi?id=204729&action=review

Thanks for the patch.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1163
> +    settings->priv->preferences->setShouldDisplaySubtitles(TRUE);

It should be true, not TRUE. If we want to enable this unconditionally, this is not the place to do it. You should change the default value of the setting for the GTK platform in Shared/WebPreferencesStore.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.