[Webkit-unassigned] [Bug 117631] [GTK] Provide search functionality to MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117631





--- Comment #3 from Andres Gomez Garcia <agomez at igalia.com>  2013-06-14 02:59:39 PST ---
(In reply to comment #2)
> Attachment 204686 [details] did not pass style-queue:
...
> Tools/MiniBrowser/gtk/BrowserSearchBar.h:48:  Extra space before ( in function call  [whitespace/parens] [4]

GObject signal definition. Without that space will be awful.

> Tools/MiniBrowser/gtk/BrowserSearchBar.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]

MiniBrowser doesn't use the config.h. Harmless false positive, not to be reported as a check-webkit-style bug.

> Tools/MiniBrowser/gtk/BrowserSearchBar.c:188:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:189:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:190:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:191:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:192:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Tools/MiniBrowser/gtk/BrowserSearchBar.c:193:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

GObject signal addition following GTK+ style. IMHO, a harmless false positive, not to be reported as a check-webkit-style bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.