[Webkit-unassigned] [Bug 117625] [EFL][WK2] Fix crash issue on ewk_context_favicon_database_directory_set()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117625





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-06-13 23:45:40 PST ---
(From update of attachment 204674)
View in context: https://bugs.webkit.org/attachment.cgi?id=204674&action=review

>>>> Source/WebKit2/UIProcess/API/C/WKContext.cpp:287
>>>> +bool WKContextSetIconDatabasePath(WKContextRef contextRef, WKStringRef iconDatabasePath)
>>> 
>>> You should avoid changing C API if possible. Most C API setters don't return bool so this seems a bit inconsistent.
>> 
>> Oh, attached another patch at the same time.
>> 
>> I'll check what you commented. Thanks
> 
> Without changing C API(returning value), can I add WK C APIs to enable and check IconDatabase's enabled flag? Because isOpen() returns false before IconDatabase's sync thread opens DB.

I think this patch also deals with common area in WK2. So, you should get a review by WK2 owner. IMHO, you're able to split this patch into common WK2 and EFL WK2.

> Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:57
> +WK_EXPORT bool WKContextSetIconDatabasePath(WKContextRef context, WKStringRef iconDatabasePath);

It looks you need to consider all ports which are using this APIs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.