[Webkit-unassigned] [Bug 117342] [curl] Merge http response header values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117342





--- Comment #11 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-06-13 09:47:40 PST ---
(In reply to comment #10)
> (From update of attachment 204580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204580&action=review
> 
> Looks great!  I had a couple of minor suggestions.  If you can clarify that comment I will be happy to approve the patch.
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:241
> > +    static const char *appendableHeaders[] = {
> 
> This should be "static const char*"  The fact that this is a "const char pointer" is part of the type.
> 

Ok.

> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:270
> > +    // Custom headers usually starts with 'X-', allow them.
> 
> "starts" should be "start" (syntax).
> 
> If they usually start with "X-", why do we test with "x-" (case insensitive)?  Do they usually start with either "X-" or "x-" and we are handling this case and exiting early?
> 
> Maybe the comments should be "Custom headers start with 'X-', and need no further checking.

The http headers are case insensitive (at least that's what I read in the rfc) and most of the times the first character is in uppercase. I'll update the comment.
.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.