[Webkit-unassigned] [Bug 116042] [GStreamer] [texmap] upload a video buffer into the video texture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116042


Sebastian Dröge <slomo at circular-chaos.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204424|review+                     |review-
               Flag|                            |




--- Comment #29 from Sebastian Dröge <slomo at circular-chaos.org>  2013-06-12 23:42:49 PST ---
(From update of attachment 204424)
View in context: https://bugs.webkit.org/attachment.cgi?id=204424&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:353
> +            if (gst_video_gl_texture_upload_meta_upload(meta, ids)) {

This looks all good

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:44
> +#define GST_SURFACE_CAPS "video/x-surface, opengl=true; "

Erm... no. There should not be any video/x-surface caps in 1.0 anywhere. Maybe you mean "video/x-raw(meta:GstVideoGLTextureMapper)" here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.