[Webkit-unassigned] [Bug 117551] [GStreamer] [texmap] the bytesPerLine is wrong when updating the texture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117551





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-06-12 10:28:34 PST ---
(From update of attachment 204451)
View in context: https://bugs.webkit.org/attachment.cgi?id=204451&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:342
> +    GRefPtr<GstCaps> caps = webkitGstGetPadCaps(m_videoSinkPad.get());

Would it be better to get the caps before the buffer and pass that as an argument? Is there any way to lock the sink and get the buffer and the caps without the possibility of a race condition? This seems like a pretty serious issue.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:344
> +    GRefPtr<GstCaps> caps = GST_BUFFER_CAPS(m_buffer);

Any reason you are getting the cap from m_buffer instead of the argument, buffer?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:349
> +    int parN, parD, stride;

Please don't abbreviate variable names. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.