[Webkit-unassigned] [Bug 116994] Setting overflow:hidden on position:absolute does not repaint hidden content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116994





--- Comment #18 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-06-11 04:20:07 PST ---
Hi Simon,

(In reply to comment #16)
> (In reply to comment #15)
> > > 
> > > > LayoutTests/fast/repaint/change-overflow-and-display-of-relative.html:32
> > > > +        }, 50);
> > > 
> > > Can this be < 50ms?
> > 
> > No, this can't.
> > I tried 0ms and used "overflow.offsetHeight;" to force to redraw.
> > However, if I open this test from Finder, the problem is sometimes not reproduced.
> > I think 1st drawing is combined with 2nd drawing.
> 
> If it's this timing sensitive on your machine, it's likely it will fail on a bot, or EWS. You should try to find a way to make the test reliable with a setTimeout. Does testRunner.display() help?
> 
> Thinking about the test some more, I think it should not be a ref test, and instead be a repaint test. See tests that call repaintRectsAsText.

testRunner.display() doesn't work well for pixel and ref test, but it works well for text based repaint test.
Therefore, I changed the test to use repaintRectsAsText for DumpRenderTree and setTimeout() for Safari.

Could you review this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.