[Webkit-unassigned] [Bug 117230] [WK2][GTK] Let DrawingArea manage setAcceleratedCompositingWindowId

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117230





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-06-10 18:33:17 PST ---
(From update of attachment 203997)
View in context: https://bugs.webkit.org/attachment.cgi?id=203997&action=review

This change seems okay to me. I have suggestions for a few changes and after that it needs the approval of a WebKit owner.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:375
> +void DrawingAreaProxyImpl::setNativeCompositingSurfaceHandle(uint64_t handle)

May I suggest a new name: setNativeSurfaceHandleForCompositing or setCompositingNativeSurfaceHandle. This eliminates any confusion between native "compositing surface handle" or a "surface handle" for native compositing.

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:99
> +#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK)
> +    virtual void setNativeCompositingSurfaceHandle(uint64_t) { }
> +#endif
> +

This is unused for this patch, so maybe it can be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.