[Webkit-unassigned] [Bug 117307] [curl] Set the http response status text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117307





--- Comment #5 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-06-10 02:20:39 PST ---
(In reply to comment #4)
> (From update of attachment 204022 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204022&action=review
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:321
> > +        else if (header.startsWith("HTTP", false)) {
> 
> what does false mean? add /* ... */ ?

The second argument specifies if the string matching should be case sensitive or not. I've never seen that someone adds the comment for this method. But I can do.

> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:323
> > +            // This is (probably) the first line of the response.
> > +            // Try to extract the http status text from this.
> 
> not very trustworthy comment, can you be more specific?
> 
> Attempt to extract HTTP status...

In case of the curl backend the FOLLOWLOCATION is set to 1, that'll mean that the libcurl will internally follow the redirections. Thus the headerCallback method will be called more than one times with the line starting "HTTP".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.