[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #42 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-07 16:32:12 PST ---
(From update of attachment 204066)
View in context: https://bugs.webkit.org/attachment.cgi?id=204066&action=review

>> Source/WebCore/html/HTMLMediaElement.cpp:4365
>> +#if PLATFORM(MAC)
> 
> Wonder if you want an #if ENABLE(TOGGLE_FULLSCREEN) or something (ugh, that seems terrible too, though). Something that other ports can turn on as they change their API instead of adding themselves to this list of (currently one) platform(s).

Yeah, this is probably a more robust implementation.

>> Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h:113
>> +#if PLATFORM(MAC)
> 
> I don't think we can add things in the middle of an API enum.

Wouldn't "Enter" and "Toggle" effectively be the same tag? (since only one will ever be enumerated, they'd share the same enum value?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.