[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #37 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-07 09:26:32 PST ---
(In reply to comment #34)
> (From update of attachment 203989 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203989&action=review
> 
> I think you should be leaving the GTK API change to people who work directly on GTK. There’s no rush to add this at the same time you add the underlying capability to WebCore.
> 
> > Source/WebKit2/Shared/API/c/WKSharedAPICast.h:472
> > -    case WebCore::ContextMenuItemTagEnterVideoFullscreen:
> > -        return kWKContextMenuItemTagEnterVideoFullscreen;
> > +    case WebCore::ContextMenuItemTagToggleVideoFullscreen:
> > +        return kWKContextMenuItemTagToggleVideoFullscreen;
> 
> I don’t understand why we are removing the enter fullscreen menu item while adding the toggle fullscreen one. Who suggested the removal? What’s the rationale?

I can continue to support "Enter" tags (and simply treat them) on GTK (and other ports as well) and leave the transition to port APIs to "Toggle" tags as another bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.