[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 7 00:26:43 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #30 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-07 00:25:16 PST ---
(From update of attachment 203989)
View in context: https://bugs.webkit.org/attachment.cgi?id=203989&action=review

>> Source/WebKit/gtk/webkit/webkitglobals.h:140
>> +    WEBKIT_CONTEXT_MENU_ACTION_TOGGLE_VIDEO_FULLSCREEN,
> 
> Isn't it possible to do the same than in wk2, instead of renaming? Otherwise we need to deprecate the ENTER one and add TOGGLE at the end.

I wonder how this could build in EWS gtk, since we are using WEBKIT_CONTEXT_MENU_ACTION_ENTER_VIDEO_FULLSCREEN in webkitglobals.cpp, are we building with CONTEXT_MENUS disabled in EWS? phil?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list