[Webkit-unassigned] [Bug 93977] Implement testRunner.numberOfPendingGeolocationPermissionRequests()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93977


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203964|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-06-06 13:47:31 PST ---
(From update of attachment 203964)
View in context: https://bugs.webkit.org/attachment.cgi?id=203964&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:679
> +        int number = TestController::shared().numberOfPendingGeolocationPermissionRequests();
> +        WKRetainPtr<WKTypeRef> result(AdoptWK, WKUInt64Create(number));
> +        return result;

The right way to write this is:

    return adoptWK(WKUInt64Create(TestController::shared().numberOfPendingGeolocationPermissionRequests()));

No need for the local variables.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.