[Webkit-unassigned] [Bug 116534] [GStreamer] Adjust internal size on http source element when receiving data if necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 6 10:07:09 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116534





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-06 10:05:42 PST ---
(In reply to comment #6)
> Created an attachment (id=203946)
 --> (https://bugs.webkit.org/attachment.cgi?id=203946&action=review) [details]
> Adjust internal size when receiving data if needed 
> 
> (In reply to comment #5)
> > (From update of attachment 202424 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=202424&action=review
> > 
> > Please, fix coding style issues before landing.
> > 
> > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1019
> > > +    // priv->size == 0 if received length on didReceiveResponse < 0
> > 
> > Nit: According to the coding style comments should finish with a period.
> > 
> Done
> 
> > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020
> > > +    if (priv->size != 0 && priv->offset > priv->size) {
> > 
> > This is confusing offset and size are both unsigned so if offset == 0 it will never be > size. This could probably just be 
> > 
> > if (priv->offset > priv->size)
> > 
> But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need to update the internal size as didReceiveResponse will disable seek, etc on the gst appsrc. No change here

You are right, I read the comparison wrongly. But still, you should do:

if (priv->size && priv->offset > priv->size)

or 

if (priv->size > 0 && priv->offset > priv->size)

to make the style bot happy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list