[Webkit-unassigned] [Bug 104360] Coordinated Graphics: Separate LayerTreeCoordinator into LayerTreeCoordinator and CompositingCoordinator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104360


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203920|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #27 from Noam Rosenthal <noam at webkit.org>  2013-06-06 07:04:54 PST ---
(From update of attachment 203920)
View in context: https://bugs.webkit.org/attachment.cgi?id=203920&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:100
> +    m_client->flushCompositingStatePeripheralLayers();

This should be called something like didFlushRootLayer(); The peripheral layers stuff should be known only to CoordinatedLTH.

> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:176
> +    m_client->prepareCustomFilterProxiesIfNeeded(state);

This should be called didSyncLayerState. The client can decide whether this is about custom filters or something else.

> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h:70
> +    class Client {
> +    public:
> +        virtual void flushCompositingStatePeripheralLayers() = 0;
> +        virtual void scheduleLayerFlushRequired() = 0;
> +        virtual void commitCoordinatedGraphicsState(CoordinatedGraphicsState&) = 0;
> +        virtual void paintContents(const GraphicsLayer*, GraphicsContext&, const IntRect& clipRect) = 0;
> +#if ENABLE(CSS_SHADERS)
> +        virtual void prepareCustomFilterProxiesIfNeeded(CoordinatedGraphicsLayerState&) = 0;
> +#endif
> +    };

This client is too specific.
The CompositingCoordinator::Client class should respond to events that compositing coordinator knows about, otherwise it looks like an artificial separation of classes...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.