[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor CoordinatedSurface to manage the lifecycle of GraphicsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108899


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203911|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #39 from Noam Rosenthal <noam at webkit.org>  2013-06-06 01:23:02 PST ---
(From update of attachment 203911)
View in context: https://bugs.webkit.org/attachment.cgi?id=203911&action=review

LGTM with nitpicks

> Source/WebCore/ChangeLog:12
> +        CoordinatedImageBacking and UpdateAtlas does not asks for the ownership

does not asks -> do not ask

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedTile.h:81
> +    virtual bool paintToSurface(const IntSize&, uint32_t& /* atlasID */, IntPoint&, CoordinatedSurface::Client*) = 0;

No need to comment atlasID

> Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.cpp:57
> +

Remove new line

> Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.h:49
> +    bool paintOnAvailableBuffer(const IntSize&, uint32_t& /* atlasID */, IntPoint& /* offset */, CoordinatedSurface::Client*);

No need to comment out parameter names

> Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:190
> +    if (!client)
> +        return;
> +

We should actually assert for the client.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.