[Webkit-unassigned] [Bug 117256] [curl] Add implementation for HTTP PUT method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117256





--- Comment #5 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-06-05 15:01:58 PST ---
(In reply to comment #4)
> (From update of attachment 203852 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203852&action=review
> 
> Looks very good.  I had a couple of things I'd like you to cleanup before we land.  Thanks!
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:484
> > + */
> 
> We don't usually add header comments like these. We prefer to have the function/method name describe what the method does.
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:556
> > + */
> 
> Comment is unecessary
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:574
> > + */
> 
> Comment is unecessary

Okay, will remove these.

> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:586
> > +    Vector<FormDataElement> elements = job->firstRequest().httpBody()->elements();
> 
> I don't think this Vector is needed.

Yeah that's true, I've missed it sorry.

I'll update the patch in a few minutes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.