[Webkit-unassigned] [Bug 117266] [WK2]: Do not loop for EINTR on close()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 14:09:52 PDT 2013


--- Comment #3 from Sergio Correia <sergio.correia at openbossa.org>  2013-06-05 14:08:25 PST ---
(In reply to comment #2)
> (From update of attachment 203869 [details])
> Given the discussion in the change log it sounds like this change is wrong. On platforms that have “the HPUX behavior” these file descriptors will be left open. And once the recommendation of the Austin group is implemented, the code will be correct on the other platforms too.
> If we need to work around the current Linux behavior, it seems to me we should call through a helper function that does the right thing for Linux. Changing all the call sites to ignore the issue and leave the file descriptors open if interrupted seems clearly the wrong thing to do.
> Am I missing something? There’s all that data about what the situation is, and then a change that seems to ignore the data.

Nope, you are not missing anything. This first patch was mostly to bring attention to the issue. 

I also agree that having a helper take care of it seems better, as we can centralize any quirks some platforms might need, and we could provide also some background on the situation. Any ideas on where we could define such helper?

Thanks for the feedback.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list