[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com




--- Comment #15 from Geoffrey Garen <ggaren at apple.com>  2013-06-05 11:35:00 PST ---
> HTMLMediaElement* mediaElement = mediaElement(); yields an error that the "called object type 'WebCore::HTMLMediaElement *" is not a function or function pointer".

Minor comment:

It's a pet peeve of mine when we give two names to the same thing -- especially if it's just because the compiler is being a bully.

My preferred way to preserve the preferred name is either

    HTMLMediaElement* mediaElement = this->mediaElement();

or

    HTMLMediaElement* mediaElement = HitTestResult::mediaElement();

That way, the name of the thing is always "media element", which is our preferred name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.