[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #10 from Jer Noble <jer.noble at apple.com>  2013-06-05 10:30:12 PST ---
(From update of attachment 203747)
View in context: https://bugs.webkit.org/attachment.cgi?id=203747&action=review

>>> Source/WebCore/rendering/HitTestResult.cpp:405
>>> +    HTMLMediaElement* mediaElt = mediaElement();
>> 
>> Nit: "mediaElt" seems odd and letters are cheap, I would spell out the variable name.
> 
> HTMLMediaElement* mediaElement = mediaElement(); yields an error that the "called object type 'WebCore::HTMLMediaElement *" is not a function or function pointer". Would this be because I'm naming the variable the same thing as a function?

Yes, and your local variable overrides the function of the same name, so the compiler thinks you're trying to call the local variable like a function pointer.

I think 'element' would be fine.

> Source/WebCore/rendering/HitTestResult.cpp:406
> +    if (mediaElt && mediaElt->hasTagName(HTMLNames::videoTag))

You should use "element->isVideo()" here instead.

--- Comment #11 from Jer Noble <jer.noble at apple.com>  2013-06-05 10:30:13 PST ---
(From update of attachment 203747)
View in context: https://bugs.webkit.org/attachment.cgi?id=203747&action=review

>>> Source/WebCore/rendering/HitTestResult.cpp:405
>>> +    HTMLMediaElement* mediaElt = mediaElement();
>> 
>> Nit: "mediaElt" seems odd and letters are cheap, I would spell out the variable name.
> 
> HTMLMediaElement* mediaElement = mediaElement(); yields an error that the "called object type 'WebCore::HTMLMediaElement *" is not a function or function pointer". Would this be because I'm naming the variable the same thing as a function?

Yes, and your local variable overrides the function of the same name, so the compiler thinks you're trying to call the local variable like a function pointer.

I think 'element' would be fine.

> Source/WebCore/rendering/HitTestResult.cpp:406
> +    if (mediaElt && mediaElt->hasTagName(HTMLNames::videoTag))

You should use "element->isVideo()" here instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.