[Webkit-unassigned] [Bug 117220] Allow for toggling fullscreen on <video> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 10:26:31 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117220





--- Comment #9 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-05 10:25:04 PST ---
(From update of attachment 203747)
View in context: https://bugs.webkit.org/attachment.cgi?id=203747&action=review

>> Source/WebCore/rendering/HitTestResult.cpp:405
>> +    HTMLMediaElement* mediaElt = mediaElement();
> 
> Nit: "mediaElt" seems odd and letters are cheap, I would spell out the variable name.

HTMLMediaElement* mediaElement = mediaElement(); yields an error that the "called object type 'WebCore::HTMLMediaElement *" is not a function or function pointer". Would this be because I'm naming the variable the same thing as a function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list