[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor GraphicsSurface and ShareableBitmap to be responsible for their GraphicsContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 07:30:24 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=108899





--- Comment #32 from Jae Hyun Park <jae.park at company100.net>  2013-06-05 07:28:56 PST ---
(In reply to comment #21)
> How about (with fake function names)
> 
> class ShareableBitmapClient  {
>   virtual drawBuffer(ShareableBitmap*, GraphicsContext*) = 0;
> }
> 
> ShareableBitmap::drawContents()
> {
>   OwnPtr<GraphicsContext> context = create.....
>   client->drawBuffer(this, context);
> }
> 
> And there would be no other way to get the GraphicsContext for a bitmap.
> 
> That way there is zero ambiguity about the GraphicsContext ownership.

It is difficult to apply ShareableBitmap client pattern to CoordinatedSurface because when CoordinatedTile requests for GraphicsContext, the GraphicsContext is modified in WebCoordinatedSurface and UpdateAtlas. Then, CoordinatedTile modifies this GraphicsContext (translate and scale), and then passes to TiledBackingStoreClient for actual painting. Therefore, it is really hard to apply this client pattern.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list