[Webkit-unassigned] [Bug 111066] svn-apply cannot apply patches which is generated by git to files that contain space characters in their path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111066





--- Comment #25 from Daniel Bates <dbates at webkit.org>  2013-06-05 05:07:39 PST ---
(From update of attachment 203682)
View in context: https://bugs.webkit.org/attachment.cgi?id=203682&action=review

>>> Tools/ChangeLog:8
>>> +        If the path in a diff has space characters, parseGitDiffHeader() considers last nonspace characters as file path.
>> 
>> I'm unclear what you mean by this sentence.
> 
> I want to describe bug cause.
> I changed this to the past tense.
> Is this make sense?

I think a better way to phrase this sentence is to write:

Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.

>>> Tools/ChangeLog:9
>>> +        When the diff have prefix, we consider next characters after "b/" as file path.
>> 
>> Is this sentence correct? I thought we currently considered the next characters after "b/" as part of a file path?
> 
> Sorry, I cannot understand your comment.
> I added "part of a", but my fix might be wrong.

OK. This sentence reads better with the proposed correction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.