[Webkit-unassigned] [Bug 111919] Coordinated Graphics: Unify messages related object's lifecycles into CoordinatedGraphicsState.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111919





--- Comment #16 from Gwang Yoon Hwang <ryumiel at company100.net>  2013-06-05 03:22:15 PST ---
(In reply to comment #15)
> (From update of attachment 203777 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203777&action=review
> 
> Great! but has a couple of unrelated changes
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:118
> > -    // If sending the message fails, try again in the next update.
> > -    bool success = m_coordinator->updateImageBacking(id(), m_surface);
> > -    m_isDirty = !success;
> > +    m_coordinator->updateImageBacking(id(), m_surface);
> > +    m_isDirty = false;
> 
> This seems unrelated
>
Because this patch does defers creating a handle of WebCoordinatedSurface to sync time, we cannot check whether it is failed, so fallback logic was removed.

I think cleaning m_isDirty is necessary because it indicates ImageBacking posts its update.

> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:402
> > +    size_t index = m_state.layersToCreate.find(layer->id());
> > +    if (index != notFound) {
> > +        m_state.layersToCreate.remove(index);
> > +        return;
> > +    }
> > +
> > +    m_state.layersToRemove.append(layer->id());
> 
> This seems unrelated as well

I think it makes sense, because it is a reused logic from 
 Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:288

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.