[Webkit-unassigned] [Bug 111066] svn-apply cannot apply patches which is generated by git to files that contain space characters in their path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 01:45:24 PDT 2013


--- Comment #24 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-06-05 01:43:57 PST ---
Hi Daniel,

Thank you for kindly review.

I fixed codes which you comment.

(In reply to comment #22)
> (From update of attachment 203682 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203682&action=review
> This patch looks good. I have some minor nits.
> > Tools/ChangeLog:8
> > +        If the path in a diff has space characters, parseGitDiffHeader() considers last nonspace characters as file path.
> I'm unclear what you mean by this sentence.

I want to describe bug cause.
I changed this to the past tense.
Is this make sense?

> > Tools/ChangeLog:9
> > +        When the diff have prefix, we consider next characters after "b/" as file path.
> Is this sentence correct? I thought we currently considered the next characters after "b/" as part of a file path?

Sorry, I cannot understand your comment.
I added "part of a", but my fix might be wrong.

> > Tools/Scripts/VCSUtils.pm:114
> > +my $gitDiffPathPrefix = qr#^diff --git ([^\/]+\/)#;
> It's unnecessary to escape the '/' character in this regular expression since we use '#' as the delimiter. Thus, we can simplify the regular expression in this line to read: ^diff --git ([^/]+/)
> On another note, I wish we could come up with a more descriptive name for this variable. Maybe $gitDiffStartWithoutPrefixFirstDirectoryNameRegExp? or $gitDiffStartWithoutPrefixSourceDirectoryPrefixRegExp? or $gitDiffStartPathPrefixRegExp?

I like $gitDiffStartWithoutPrefixSourceDirectoryPrefixRegExp :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list