[Webkit-unassigned] [Bug 117221] Modify scripts to support VS2010 build environment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117221


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203750|review?                     |review-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-06-04 21:13:03 PST ---
(From update of attachment 203750)
View in context: https://bugs.webkit.org/attachment.cgi?id=203750&action=review

Looks good, but I think we want to keep the WEBKIT_SOURCE environment setup.

> Scripts/webkitdirs.pm:-1583
> -        $variablesToSet{WEBKIT_SOURCE} = windowsSourceSourceDir() unless $ENV{WEBKIT_SOURCE};

I don't think you want to get rid of this one!

> Scripts/webkitdirs.pm:-1624
> -        }

Ditto -- don't we need this?

> Scripts/webkitdirs.pm:-1669
> -    }

Getting rid of this stanza is good ....

> Scripts/webkitdirs.pm:-1673
> -    }

... but getting rid of this stanza is not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.