[Webkit-unassigned] [Bug 70117] Expose HTMLCanvasElement supportsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70117


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203623|review?                     |review-
               Flag|                            |




--- Comment #27 from Dean Jackson <dino at apple.com>  2013-06-03 13:36:20 PST ---
(From update of attachment 203623)
View in context: https://bugs.webkit.org/attachment.cgi?id=203623&action=review

Just a few minor questions.

> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:122
> +            if (!dictionary.tryGetProperty("antialias", graphicattrs.premultipliedAlpha))
> +                return jsUndefined();

Is this correct? antialias corresponds to premultiplied? I don’t think that sounds right.

> Source/WebCore/html/HTMLCanvasElement.cpp:219
> +        if (m_context && !m_context->is2d())
> +            return false;
> +        return true;

Might as well make this return (!m_context || m_context->is2d())

> Source/WebCore/html/HTMLCanvasElement.cpp:235
> +            if (m_context && !m_context->is3d())
> +                return false;
> +            return true;

Same here.

> LayoutTests/fast/canvas/webgl/canvas-supports-context.html:33
> +function check_context(type_of_context) {

Please put this at the top of the <script>

> LayoutTests/fast/canvas/webgl/canvas-supports-context.html:59
> +        testPassed("supportsContext('" + type_of_context + "') is consistent with getContext('" + type_of_context + "')");
> +
> +if (window.testRunner)
> +    testRunner.notifyDone();
> +}

I’m a bit confused here. It looks like the check_context function includes this notifyDone(). Is that intentional? The indentation implies not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.