[Webkit-unassigned] [Bug 115406] [GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115406


Eduardo Lima Mitev <elima at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203567|0                           |1
        is obsolete|                            |
 Attachment #203567|review?, commit-queue?      |
               Flag|                            |
 Attachment #203603|                            |review?, commit-queue?
               Flag|                            |




--- Comment #11 from Eduardo Lima Mitev <elima at igalia.com>  2013-06-03 09:38:13 PST ---
Created an attachment (id=203603)
 --> (https://bugs.webkit.org/attachment.cgi?id=203603&action=review)
last patch removing the cairo_new_path(), which was not required

After discussing a bit with mrobinson, I learned that it should not be required to cairo_new_path() at the beginning of drawErrorUnderline(). These routines should assume and respect a clean path.

This new patch just removes the call to cairo_new_path() in drawErrorUnderline(), and just add the cairo_fill() at the end.

Tests are passing and all looks ok to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.