[Webkit-unassigned] [Bug 117040] Resolve generic families without FontSelector
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 3 06:56:29 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=117040
--- Comment #21 from WebKit Commit Bot <commit-queue at webkit.org> 2013-06-03 06:55:01 PST ---
Attachment 203583 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontGenericFamilies.cpp', u'Source/WebCore/platform/graphics/FontGenericFamilies.h', u'Source/WebCore/platform/graphics/FontGlyphs.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontSelector.h', u'Source/WebCore/rendering/style/RenderStyle.cpp']" exit_code: 1
Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/Font.h:104: The parameter name "genericFamilies" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list