[Webkit-unassigned] [Bug 115406] [GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115406





--- Comment #9 from Eduardo Lima Mitev <elima at igalia.com>  2013-06-03 04:46:44 PST ---
(In reply to comment #8)
> 
> Was there a test failing because a path was remaining on the context?

Without the calls to new_path() and fill(), the drawings are never committed so the underline is never visible. Implementation of drawErrorUnderline() expected the path to be opened and closed outside, but I don't think the Win port was doing that, as far as I could research.

pango_cairo_show_error_underline() calls new_path() and fill() at the beginning and ending (respectively) of the draw_error_underline() method <https://git.gnome.org/browse/pango/tree/pango/pangocairo-render.c#n614>, conditionally. After the replacement by the custom drawErrorUnderline(), I had to make these calls explicit. First I though adding them in GraphicsContext::drawLineForDocumentMarker(), but I then decided to put them in drawErrorUnderline() itself for better encapsulation, and also because I think the Win port needs that as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.