[Webkit-unassigned] [Bug 117132] onended Event is not received in AudioBufferSourceNode and OscillatorNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117132


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203564|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Christophe Dumez <dchris at gmail.com>  2013-06-03 03:35:03 PST ---
(From update of attachment 203564)
View in context: https://bugs.webkit.org/attachment.cgi?id=203564&action=review

Looks good, r=me. But please improve the Changelogs before landing.

> Source/WebCore/ChangeLog:3
> +        onended Event is not received in AudioBufferSourceNode and OscillatorNode.

'onevent' event...

> Source/WebCore/ChangeLog:8
> +        PassRefPtr is set to null after usage in setAttributeEventListener().

This would be better IMHO: "The listener argument is a PassRefPtr which becomes NULL after the call to setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener boolean to be incorrectly initialized. This patch reverses the two statements so that the m_hasEndedListener is updated before the call to setAttributeEventListener()."

> Source/WebCore/ChangeLog:11
> +        No new tests. Present layout tests will cover all the scenarios.

No new tests, already covered by existing tests.

> LayoutTests/ChangeLog:8
> +        Re-enabling failed webaudio tests due to 'onended' event not being

"Unskip webaudio test cases that were failing due to the 'onended' event not being fired."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.