[Webkit-unassigned] [Bug 118195] [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118195


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205727|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Daniel Bates <dbates at webkit.org>  2013-06-28 12:38:39 PST ---
(From update of attachment 205727)
View in context: https://bugs.webkit.org/attachment.cgi?id=205727&action=review

> Tools/Scripts/webkitdirs.pm:1884
> +        pop(@jhbuildPath);

This line is error prone as it depends on the implementation detail that baseProductDir() always appends a "/" to the end of the base product path when it's a Git branch build by line 239 of webkitdirs.pm (r152104), <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm?rev=152104#L239>. This detail is likely to change as we move towards using File::Spec operations to build a file system path instead of string concatenation to build a path. I suggest that we pop() the last directory only if it's a Git branch build and gitBranch() is a non-empty string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.