[Webkit-unassigned] [Bug 112615] [css3-text] Implement support for vertical writing mode in -webkit-text-underline-position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112615





--- Comment #17 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-06-27 23:30:25 PST ---
(In reply to comment #15)
> > I don't think so.
> > I think your draft patch needs assert because it is not clear whether list is empty or not.
> > However, my implementation is copied from renderTextDecorationFlagsToCSSValue().
> > Since "if" at 2nd line above the return line assures that list must not be empty, and there is no assert in renderTextDecorationFlagsToCSSValue().
> 
> "none" is a valid value for TextDecoration (http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-property), that is why defaulting to CSSValueNone when the list is empty is Ok there and no assert is needed there. However, "none" is not a valid value for text-underline-position, so the list must not be empty, an assert is needed and we should not default to CSSValueNone.

Changed to use "auto", and changed definition of TextUnderlinePosition constants.
It make underline-position's code more like text-decoration's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.