[Webkit-unassigned] [Bug 118053] Parsing of MathML length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118053





--- Comment #15 from chris fleizach <cfleizach at apple.com>  2013-06-27 12:24:39 PST ---
(From update of attachment 205585)
View in context: https://bugs.webkit.org/attachment.cgi?id=205585&action=review

otherwise this looks good

> Source/WebCore/rendering/mathml/RenderMathMLBlock.h:131
> +//

this comment can likely be removed. you can probably name the parameters and their uses will be self evident. certainly style and allowNegative need no introduction

> Source/WebCore/rendering/mathml/RenderMathMLBlock.h:146
> +bool parseNamedSpace(const String&, float&, const RenderStyle*, bool allowNegative = true);

parseNamedSpace should probably be named similar to parseMathMLLength (parseMathMLNamedSpaceUnit or something)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.