[Webkit-unassigned] [Bug 118123] Porting spellcheck tests from layout tests to unit tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118123


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205594|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Christophe Dumez <dchris at gmail.com>  2013-06-27 05:44:06 PST ---
(From update of attachment 205594)
View in context: https://bugs.webkit.org/attachment.cgi?id=205594&action=review

Looks fine. r=me with nits. Please fix the nits and let Grzegorz take a look before landing.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:340
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:369
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:398
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:428
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.