[Webkit-unassigned] [Bug 118128] New: [webkitpy] AbstractPatchSequencingCommand should have _prepare_state

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 27 05:34:03 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118128

           Summary: [webkitpy] AbstractPatchSequencingCommand should have
                    _prepare_state
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: galpeter at inf.u-szeged.hu, rniwa at webkit.org,
                    jbadics at inf.u-szeged.hu
            Blocks: 117831


AbstractSequencedCommand already has _prepare_state method to let 
its subclasses to prepare an initial state, set options, etc.
for example: queries.py/SuggestReviewers, download.py/Clean,Build,Land

Unfortunately AbstractPatchSequencingCommand doesn't have _prepare_state method
to do similar things, we can only use prepare_steps. But it's overkiller to
implement new steps for trivial things, like setting an option.

It is a dependency for the new run-tests-touched-by-attachment command,
see https://bugs.webkit.org/show_bug.cgi?id=117831#c3 for details.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list