[Webkit-unassigned] [Bug 118123] Porting spellcheck tests from layout tests to unit tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 27 03:43:51 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118123





--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-06-27 03:45:47 PST ---
(From update of attachment 205583)
View in context: https://bugs.webkit.org/attachment.cgi?id=205583&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:54
> +static size_t contextMenuItemsNumber = 0;

Please use unsigned as this is the type returned by eina_list_count().

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:329
> +    size_t numberItemsWithoutSpellCheck = contextMenuItemsNumber;

unsigned

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:338
> +    size_t numberItemsWithSpellCheck = contextMenuItemsNumber;

unsigned

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:342
> +    wasContextMenuShown = false;

I don't think we should reset the boolean at the end of the test. The next test should set the boolean value before using it instead.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:371
> +    wasContextMenuShown = false;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list