[Webkit-unassigned] [Bug 117230] [WK2][GTK] Let DrawingArea manage setAcceleratedCompositingWindowId

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117230





--- Comment #5 from Gwang Yoon Hwang <ryumiel at company100.net>  2013-06-26 05:19:14 PST ---
(In reply to comment #3)
> (From update of attachment 203997 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203997&action=review
> 
> This change seems okay to me. I have suggestions for a few changes and after that it needs the approval of a WebKit owner.
> 
Sorry for late. :(

> > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:375
> > +void DrawingAreaProxyImpl::setNativeCompositingSurfaceHandle(uint64_t handle)
> 
> May I suggest a new name: setNativeSurfaceHandleForCompositing or setCompositingNativeSurfaceHandle. This eliminates any confusion between native "compositing surface handle" or a "surface handle" for native compositing.
>

I prefer setNativeSurfaceHandleForCompositing. I've renamed with it.

> > Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:99
> > +#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK)
> > +    virtual void setNativeCompositingSurfaceHandle(uint64_t) { }
> > +#endif
> > +
> 
> This is unused for this patch, so maybe it can be removed.
Yes, exactly. removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.