[Webkit-unassigned] [Bug 118049] New: Simplify Node::isDescendantOf TreeScope check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 00:15:13 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118049

           Summary: Simplify Node::isDescendantOf TreeScope check
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, benjamin at webkit.org, akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/1f32ca1d3a07dd597970dfbabb8dc7d380aad742

Node::isDescendantOf has a round about way of checking that two nodes are
in the same TreeScope so when doing document.contains(node) where node
is in a ShadowRoot it returns false. This can be greatly simplified and
we can make a.contains(b) O(1) when a and b are in different ShadowRoots
or Documents.


We need to be careful here. The old code was optimized for the case when one of the node was not in the tree. We should make sure that optimization isn't broken.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list