[Webkit-unassigned] [Bug 118018] New: Remove unneeded static_casts from SelectorChecker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 25 20:12:55 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118018

           Summary: Remove unneeded static_casts from SelectorChecker
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, esprehn at chromium.org,
                    benjamin at webkit.org, akling at apple.com


Merge https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367

SelectorChecker::checkOne casts to StyledElement just to call classNames, but
this method is on Element so there's no reason for this. The cast here also
looks pretty suspect. The method also casts to HTMLFrameElementBase to call
containsFullScreenElement which is also on Element so the cast can be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list