[Webkit-unassigned] [Bug 118010] New: Don't shrink RuleSets multiple times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118010

           Summary: Don't shrink RuleSets multiple times
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, barraclough at apple.com,
                    benjamin at webkit.org, akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/b0a801f4bc10f6671e39443670331482d07dfb43

Don't shrink RuleSets multiple times

When the RuleSet was vectorized, there was some careful code to shrink the
vectors only once. Over time, that fragile code broke in various refactorings,
and now we end up shrinking RuleSets once per style sheet in the common case.

This CL switches the design to be more robust by introducing a bool in RuleSet
to remember whether we're supposed to shrink the vectors down to size. This CL
prepares to add an intermediate representation to RuleSet that will reduce peak
memory, but the guts of that change will be in a subsequent CL.

This CL also makes the data members of RuleSet private. They've been public
for a number of years, but our current style is to have class members be
private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.