[Webkit-unassigned] [Bug 118007] New: Introduce toHTMLFormControlElement and use it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118007

           Summary: Introduce toHTMLFormControlElement and use it
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: tkent at chromium.org, jonlee at apple.com,
                    ruthiecftg at gmail.com


https://chromium.googlesource.com/chromium/blink/+/6808b29390234652e9a3b30fe2bba67b83247134

Note for 'alias'-related changes in HTMLFormElement:
We had unnecessary cast from Node to HTMLFormControlElement.
m_elementAliases can contain HTMLImageElement and HTMLObjectElement
in addition to HTMLFormControlElement. A node was cast to
HTMLFormControlElement wrongly, but it was harmless because nodes
stored in m_elementAliases are used as Node*.


Note for the HTMLSelectElement.h change:
HTMLKeyGenElement::reset() wants to call HTMLSelectElement::reset(), and
it was realized by a cast to HTMLFormControlElement, of which reset() is
public. Replacing the cast to toHTMLFormControlElement doesn't work
because both of toHTMLFormControlElement(Node*) and
toHTMLFormControlElement(FormAssociatedElement*) match to an
HTMLSelectElement argument.
The public reset() makes the code simpler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.